Skip to content

[fix](float) Fix float field to_string #58176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2025
Merged

[fix](float) Fix float field to_string #58176

merged 2 commits into from
Nov 21, 2025
+35 −50

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Nov 20, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented Nov 20, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 20, 2025

TPC-H: Total hot run time: 34211 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e0018901d17eb9b9245c5ff58280459aef9938a6, data reload: false

------ Round 1 ----------------------------------
q1	17653	5062	4910	4910
q2	2264	310	208	208
q3	10734	1302	737	737
q4	10263	916	373	373
q5	7460	2352	2360	2352
q6	190	171	141	141
q7	914	759	625	625
q8	9346	1353	1121	1121
q9	7035	5473	5360	5360
q10	7017	2231	1807	1807
q11	499	299	286	286
q12	340	356	227	227
q13	17771	3649	3031	3031
q14	229	225	214	214
q15	584	503	510	503
q16	1025	981	933	933
q17	630	859	356	356
q18	7402	7034	7172	7034
q19	1143	966	547	547
q20	341	334	234	234
q21	3715	3167	2237	2237
q22	1052	1016	975	975
Total cold run time: 107607 ms
Total hot run time: 34211 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4994	4941	4929	4929
q2	324	391	314	314
q3	2161	2680	2342	2342
q4	1320	1745	1300	1300
q5	4147	4515	4443	4443
q6	206	174	129	129
q7	2047	1933	1822	1822
q8	2622	2642	2579	2579
q9	7645	7596	7571	7571
q10	3035	3304	2808	2808
q11	578	527	499	499
q12	649	806	608	608
q13	3566	3894	3518	3518
q14	295	299	276	276
q15	528	505	509	505
q16	1096	1075	1065	1065
q17	1173	1563	1379	1379
q18	7823	7698	7535	7535
q19	827	818	902	818
q20	2013	2143	1940	1940
q21	4632	4319	4267	4267
q22	1113	1057	997	997
Total cold run time: 52794 ms
Total hot run time: 51644 ms

@doris-robot
Copy link

doris-robot commented Nov 20, 2025

TPC-DS: Total hot run time: 187609 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e0018901d17eb9b9245c5ff58280459aef9938a6, data reload: false

query1	1145	416	383	383
query2	6542	1736	1670	1670
query3	6836	232	224	224
query4	26446	23186	22680	22680
query5	4415	656	521	521
query6	337	239	228	228
query7	4683	495	310	310
query8	308	276	254	254
query9	8610	2911	2938	2911
query10	492	331	320	320
query11	15850	14959	14730	14730
query12	183	125	116	116
query13	1706	583	452	452
query14	10661	9085	9044	9044
query15	206	185	172	172
query16	7295	663	508	508
query17	1259	783	632	632
query18	2004	435	347	347
query19	213	211	196	196
query20	132	126	123	123
query21	264	140	125	125
query22	4254	4135	4007	4007
query23	33981	33105	33064	33064
query24	8129	2412	2374	2374
query25	638	558	481	481
query26	1250	280	173	173
query27	2730	503	381	381
query28	4375	2237	2219	2219
query29	860	636	536	536
query30	298	216	196	196
query31	930	806	721	721
query32	98	83	81	81
query33	579	418	363	363
query34	772	867	561	561
query35	819	821	737	737
query36	953	962	904	904
query37	128	112	94	94
query38	3510	3473	3430	3430
query39	1490	1408	1392	1392
query40	230	133	127	127
query41	62	59	62	59
query42	127	114	113	113
query43	486	486	459	459
query44	1267	808	812	808
query45	188	180	169	169
query46	873	978	644	644
query47	1748	1794	1748	1748
query48	382	436	328	328
query49	773	496	410	410
query50	655	682	413	413
query51	3952	3852	3878	3852
query52	117	122	123	122
query53	240	261	205	205
query54	313	314	300	300
query55	92	92	93	92
query56	335	378	343	343
query57	1177	1204	1121	1121
query58	295	293	287	287
query59	2555	2650	2502	2502
query60	364	363	345	345
query61	166	158	157	157
query62	774	703	681	681
query63	228	193	192	192
query64	4496	1143	881	881
query65	3989	3939	3915	3915
query66	1173	431	354	354
query67	15333	15057	14884	14884
query68	8337	955	638	638
query69	497	343	296	296
query70	1332	1277	1224	1224
query71	491	351	324	324
query72	5990	4872	4835	4835
query73	672	565	363	363
query74	8979	9060	8877	8877
query75	3962	3283	2755	2755
query76	3756	1126	729	729
query77	809	410	336	336
query78	9422	9526	8856	8856
query79	2458	813	631	631
query80	636	595	523	523
query81	497	259	227	227
query82	487	162	146	146
query83	264	257	250	250
query84	262	111	91	91
query85	940	504	453	453
query86	403	307	306	306
query87	3688	3674	3642	3642
query88	3715	2256	2220	2220
query89	389	337	311	311
query90	1972	246	234	234
query91	162	157	133	133
query92	96	77	74	74
query93	1863	1008	685	685
query94	704	423	344	344
query95	413	341	340	340
query96	483	576	280	280
query97	3067	2955	2839	2839
query98	249	222	213	213
query99	1386	1381	1263	1263
Total cold run time: 276152 ms
Total hot run time: 187609 ms

@doris-robot
Copy link

doris-robot commented Nov 20, 2025

ClickBench: Total hot run time: 27.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e0018901d17eb9b9245c5ff58280459aef9938a6, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.04	0.05
query3	0.25	0.08	0.08
query4	1.63	0.11	0.11
query5	0.27	0.25	0.25
query6	1.18	0.66	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.05
query9	0.57	0.53	0.53
query10	0.57	0.57	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.59	0.60
query14	1.01	0.99	1.00
query15	0.85	0.82	0.82
query16	0.38	0.39	0.38
query17	0.97	1.04	1.05
query18	0.21	0.20	0.20
query19	1.86	1.83	1.81
query20	0.01	0.02	0.01
query21	15.45	0.19	0.13
query22	5.06	0.07	0.05
query23	15.72	0.26	0.10
query24	2.60	1.60	0.45
query25	0.09	0.07	0.05
query26	0.15	0.14	0.13
query27	0.06	0.05	0.05
query28	4.90	1.12	0.94
query29	12.57	3.98	3.27
query30	0.28	0.14	0.11
query31	2.82	0.57	0.39
query32	3.23	0.55	0.47
query33	3.04	3.00	3.05
query34	15.93	5.13	4.52
query35	4.56	4.59	4.50
query36	0.66	0.49	0.48
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.03	0.04	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 98.57 s
Total hot run time: 27.4 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 20, 2025

BE UT Coverage Report

Increment line coverage 25.00% (2/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.66% (18279/34709)
Line Coverage 38.07% (166147/436403)
Region Coverage 33.03% (129194/391158)
Branch Coverage 33.81% (55431/163939)

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 20, 2025

BE Regression && UT Coverage Report

Increment line coverage 25.00% (2/8) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.48% (24347/34059)
Line Coverage 57.92% (252847/436534)
Region Coverage 53.20% (210896/396430)
Branch Coverage 54.57% (90004/164940)

@Gabriel39
Copy link
Contributor Author

Gabriel39 commented Nov 21, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 21, 2025

TPC-H: Total hot run time: 34558 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fe257005456b95a682480a98ae9eeb6e9e47803f, data reload: false

------ Round 1 ----------------------------------
q1	17646	5081	4933	4933
q2	2080	310	199	199
q3	10243	1285	739	739
q4	10229	960	376	376
q5	7537	2468	2395	2395
q6	190	171	141	141
q7	950	798	632	632
q8	9354	1304	1134	1134
q9	7196	5475	5453	5453
q10	6939	2245	1806	1806
q11	496	306	285	285
q12	374	396	230	230
q13	17773	3669	3048	3048
q14	232	239	215	215
q15	586	510	512	510
q16	1045	1007	959	959
q17	595	917	365	365
q18	7542	7040	6997	6997
q19	1093	956	584	584
q20	363	354	228	228
q21	4017	3248	2377	2377
q22	1070	1026	952	952
Total cold run time: 107550 ms
Total hot run time: 34558 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4989	5035	5002	5002
q2	344	420	327	327
q3	2193	2679	2279	2279
q4	1397	1760	1365	1365
q5	4255	4600	4448	4448
q6	217	179	132	132
q7	2003	2074	1798	1798
q8	2693	2746	2624	2624
q9	7706	7703	7548	7548
q10	3078	3230	2894	2894
q11	611	536	522	522
q12	683	761	625	625
q13	3607	4012	3331	3331
q14	291	307	265	265
q15	557	494	530	494
q16	1085	1115	1038	1038
q17	1236	1586	1408	1408
q18	7802	7847	7493	7493
q19	829	939	956	939
q20	1913	1963	1820	1820
q21	4681	4408	4305	4305
q22	1079	1046	979	979
Total cold run time: 53249 ms
Total hot run time: 51636 ms

@doris-robot
Copy link

doris-robot commented Nov 21, 2025

TPC-DS: Total hot run time: 187289 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fe257005456b95a682480a98ae9eeb6e9e47803f, data reload: false

query1	1037	412	392	392
query2	6552	1643	1694	1643
query3	6763	229	228	228
query4	26396	23185	23053	23053
query5	4409	626	486	486
query6	344	251	228	228
query7	4649	500	310	310
query8	319	280	257	257
query9	8731	2601	2610	2601
query10	501	345	299	299
query11	15621	15085	14860	14860
query12	181	124	114	114
query13	1706	621	446	446
query14	10255	9152	9237	9152
query15	201	192	168	168
query16	7385	711	474	474
query17	1240	736	623	623
query18	1998	412	337	337
query19	210	213	181	181
query20	136	126	118	118
query21	207	135	110	110
query22	3941	4014	3944	3944
query23	33872	32924	33107	32924
query24	8427	2420	2426	2420
query25	604	574	484	484
query26	1245	282	172	172
query27	2730	497	358	358
query28	4429	2202	2180	2180
query29	867	653	511	511
query30	320	224	196	196
query31	889	787	704	704
query32	90	76	79	76
query33	613	401	336	336
query34	807	873	545	545
query35	814	838	729	729
query36	961	1001	895	895
query37	136	118	95	95
query38	3600	3543	3406	3406
query39	1485	1465	1409	1409
query40	230	131	124	124
query41	74	75	72	72
query42	133	116	116	116
query43	490	501	475	475
query44	1307	785	786	785
query45	188	186	177	177
query46	910	1001	659	659
query47	1732	1782	1698	1698
query48	420	442	341	341
query49	795	486	418	418
query50	685	701	416	416
query51	3919	4052	3861	3861
query52	118	122	116	116
query53	258	278	200	200
query54	318	309	294	294
query55	93	91	93	91
query56	342	348	332	332
query57	1165	1210	1113	1113
query58	299	285	276	276
query59	2499	2594	2618	2594
query60	354	346	334	334
query61	158	153	160	153
query62	778	697	684	684
query63	236	200	198	198
query64	4574	1173	872	872
query65	4041	3917	3970	3917
query66	1187	444	345	345
query67	15301	14898	14973	14898
query68	8389	982	634	634
query69	496	340	293	293
query70	1323	1280	1235	1235
query71	511	352	315	315
query72	5904	4945	4831	4831
query73	661	586	366	366
query74	8887	9206	8711	8711
query75	3974	3321	2812	2812
query76	3752	1194	770	770
query77	834	427	311	311
query78	9497	9671	8912	8912
query79	2003	859	612	612
query80	643	581	502	502
query81	508	256	235	235
query82	482	158	130	130
query83	268	266	251	251
query84	251	115	93	93
query85	967	497	438	438
query86	386	333	296	296
query87	3731	3755	3627	3627
query88	3751	2249	2272	2249
query89	392	327	292	292
query90	1982	232	225	225
query91	177	168	148	148
query92	85	71	69	69
query93	1782	1043	687	687
query94	691	455	308	308
query95	407	327	315	315
query96	494	568	284	284
query97	2916	2968	2837	2837
query98	236	209	213	209
query99	1304	1386	1269	1269
Total cold run time: 274959 ms
Total hot run time: 187289 ms

@doris-robot
Copy link

doris-robot commented Nov 21, 2025

ClickBench: Total hot run time: 27.41 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fe257005456b95a682480a98ae9eeb6e9e47803f, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.08	0.08
query4	1.62	0.10	0.11
query5	0.28	0.26	0.25
query6	1.14	0.64	0.64
query7	0.04	0.03	0.02
query8	0.05	0.04	0.04
query9	0.58	0.52	0.51
query10	0.58	0.57	0.56
query11	0.15	0.11	0.11
query12	0.14	0.12	0.12
query13	0.62	0.60	0.60
query14	1.00	1.01	1.01
query15	0.85	0.83	0.85
query16	0.38	0.39	0.39
query17	1.06	1.02	1.05
query18	0.20	0.20	0.19
query19	1.93	1.75	1.81
query20	0.02	0.01	0.02
query21	15.44	0.21	0.14
query22	4.95	0.07	0.05
query23	15.68	0.25	0.10
query24	3.05	0.57	0.46
query25	0.07	0.06	0.08
query26	0.14	0.14	0.13
query27	0.07	0.05	0.06
query28	3.90	1.13	0.92
query29	12.57	3.92	3.24
query30	0.30	0.13	0.12
query31	2.82	0.60	0.37
query32	3.23	0.55	0.47
query33	3.01	3.08	3.00
query34	15.87	5.20	4.54
query35	4.55	4.59	4.56
query36	0.68	0.49	0.49
query37	0.10	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 97.93 s
Total hot run time: 27.41 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 21, 2025

BE UT Coverage Report

Increment line coverage 51.85% (14/27) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.63% (18280/34733)
Line Coverage 38.08% (166361/436851)
Region Coverage 33.04% (129392/391626)
Branch Coverage 33.83% (55521/164107)

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 21, 2025

BE Regression && UT Coverage Report

Increment line coverage 51.85% (14/27) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.52% (24383/34094)
Line Coverage 57.99% (253412/437017)
Region Coverage 53.22% (211238/396934)
Branch Coverage 54.62% (90180/165118)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 7d0cae4 into apache:master Nov 21, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Gabriel39 @Thearas @doris-robot @hello-stephen @yiguolei @zhangstar333